-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ESLint to replace double quotes #30107
base: main
Are you sure you want to change the base?
Conversation
@@ -155,7 +155,7 @@ export default class Card extends PureComponent { | |||
}; | |||
|
|||
if (largeImage && card.get('type') === 'video') { | |||
thumbnailStyle.aspectRatio = `16 / 9`; | |||
thumbnailStyle.aspectRatio = '16 / 9'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially could skip these too, with the allowTemplateLiterals
@renchap this might conflict with some of your conversion PRs, since they reminded me of this :) |
This pull request has merge conflicts that must be resolved before it can be merged. |
c6320ed
to
fa20f86
Compare
This pull request has resolved merge conflicts and is ready for review. |
fa20f86
to
c00bacf
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
c00bacf
to
4cee2a0
Compare
This pull request has resolved merge conflicts and is ready for review. |
This pull request has merge conflicts that must be resolved before it can be merged. |
4cee2a0
to
47ddf9c
Compare
This pull request has resolved merge conflicts and is ready for review. |
Thought this might be easier since the Prettier way makes many more changes.
Ran
npx eslint --fix --rule 'quotes: [error, "single", {"avoidEscape": true}]' "**/*.jsx"
andnpx eslint --fix --rule 'quotes: [error, "single", {"avoidEscape": true}]' "**/*.js"
to just fix the quotes that aren't used to avoid escaping